demo(authbridge): fail fast in echo demo preflight when python-keycloak is missing#468
demo(authbridge): fail fast in echo demo preflight when python-keycloak is missing#468huang195 wants to merge 1 commit into
Conversation
make demo-echo previously failed at the late setup-keycloak step (after building images, overriding the operator, and deploying) when python-keycloak was missing. Move the check into preflight so it fails before any of that. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Hai Huang <huang195@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a preflight dependency check to the echo demo Makefile. The ChangesPreflight Dependency Check
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Superseded by #470 (combined with the abctl pipeline-panic fix). |
Summary
Follow-up to #464 (credential placeholder-swap). Small UX fix to the
echodemo'smake demo-echo.make demo-echocheckspython-keycloakonly inside the latesetup-keycloaktarget. When the package is missing, the demo fails after building the sidecar + demo images, overriding the operator's platform config, and deploying the agent/upstream — wasting all of that work before erroring on a missing pip package.This moves the
python-keycloakcheck intopreflight(the first step ofdemo-echo), so it fails fast with a clear install hint before any build/deploy/cluster mutation.preflightalready checks PyYAML the same way.Change
@python3 -c 'import keycloak' 2>/dev/null || { \ echo "ERROR: python-keycloak is required (used later by setup-keycloak)."; \ echo " Install: pip install python-keycloak"; \ ... exit 1; \ }Demo-only; no production code touched.
Attribution
Assisted-By: Claude Code
Summary by CodeRabbit