-
Notifications
You must be signed in to change notification settings - Fork 38
Refactor: Collapse authbridge-lite into a build-tag variant of authbridge-proxy #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
huang195
merged 4 commits into
rossoctl:main
from
huang195:refactor/authbridge-lite-build-tags
Jun 25, 2026
+173
−890
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bd3c1e7
refactor(authbridge): collapse authbridge-lite into a build-tag varia…
huang195 809aa2d
refactor(authbridge): make jwt-validation and token-exchange excludab…
huang195 2d4a677
refactor(authbridge): address review — test the lite tag set in CI; f…
huang195 c0d9114
test(authbridge): guard spiffeIdentityType against drift from token-e…
huang195 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
This doc still mixes the old layout with the new build-variant model.
The updated table/module text now treats
authbridge-liteas an image variant, but the section intro above still says “Three mode-specific binaries, one Dockerfile per binary,” and the later “Gotchas and Known Issues” note still says the repo has a single Go module atauthbridge/proxy-init/go.mod. Please update those stale lines too so the contributor docs describe one consistent structure.🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially addressed in 2d4a677. Fixed the stale "lite is a binary" lines I'd missed:
CLAUDE.md:122("Three mode-specific binaries…" → two + lite build variant),authbridge/CLAUDE.md(the### AuthBridge Binaries (cmd/authbridge-{proxy,envoy,lite}/)heading and the Go-module list), andauthbridge/cmd/README.md("Three…/All three binaries").The quoted "single Go module at
authbridge/proxy-init/go.mod" gotcha line wasn't found inCLAUDE.mdorauthbridge/CLAUDE.mdas written, so there was nothing to change there — the module/workspace layout is already described viaauthbridge/go.work+authbridge/authlib/.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Length of output: 5863
@huang195, thanks for the update — I rechecked the current branch.The stale “lite is a binary” wording does look fixed, including the
CLAUDE.mdbinaries section and theauthbridge/CLAUDE.mdheading.There is still one remaining stale line in the root doc, though:
CLAUDE.mdLine 307 currently says:So the “single Go module” part of my original comment is still applicable, but only for
CLAUDE.mdLine 307. Updating that line to reflect the current workspace/module layout (authbridge/go.work,authbridge/authlib/, and the cmd modules) should fully resolve this thread.🧠 Learnings used