Refactor: Rename rossocortex → cortex (fix module paths)#680
Merged
Conversation
…ortex Follow-up to the Rossoctl rename (rossoctl#678 merged the kagenti→rossoctl content but not the later rossocortex→cortex change). The repo is now rossoctl/cortex, yet its 8 Go modules still declared github.com/rossoctl/rossocortex/... — a module-path mismatch that breaks `go get`/imports of github.com/rossoctl/cortex/... . Sweeps all rossocortex → cortex: - Go modules (8): github.com/rossoctl/rossocortex/... → github.com/rossoctl/cortex/... (+ internal replace directives) - Images: ghcr.io/rossoctl/rossocortex/* → ghcr.io/rossoctl/cortex/* - Brand/prose: RossoCortex/Rossocortex → Cortex Verification: grep clean of rossocortex and kagenti; authbridge-cpex + demos build. authlib/authbridge-envoy/authbridge-proxy still depend on github.com/rossoctl/ context-guru, which is org-moved but not yet module-path-renamed (its go.mod still declares github.com/kagenti/context-guru) — so `go mod tidy` there is blocked until context-guru itself is renamed + republished; real go.sum checksums regenerate then. Related to #1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
|
Important Review skippedToo many files! This PR contains 214 files, which is 114 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (214)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mrsabath
requested changes
Jul 20, 2026
mrsabath
left a comment
mrsabath
left a comment
Contributor
There was a problem hiding this comment.
Summary
This is the right fix for the module-path mismatch — the 8 Go modules move from github.com/rossoctl/rossocortex/... to github.com/rossoctl/cortex/... (matching the repo name), with replace directives updated in lockstep. Verified the authlib self-module rename is correct. Signed-off ✅.
Requesting changes on one blocking item (the PR title), which is a required check here.
Blocking
verify-pr-titlefails and will block merge. The title⚠️ Rename rossocortex → cortex (fix module paths)doesn't start with an allowed prefix — the check only acceptsBuild, Chore, CI, Docs, Feat, Fix, Perf, Refactor, Revert, Style, Test, Feature, Bug fix, Proposal, Breaking change, Other/Misc. Retitle with one of those, e.g.Refactor: Rename rossocortex → cortex (fix module paths). Trivial, but it's a hard required check on this repo.
Non-blocking (correctly scoped out by the author)
Go CI (authlib)fails with:github.com/rossoctl/context-guru@v0.0.0-20260713113308-b624f2c3d8c2: parsing go.mod: module declares its path as: github.com/kagenti/context-guru but was required as: github.com/rossoctl/context-gururossoctl/context-guruwas org-moved but its go.mod still declaresmodule github.com/kagenti/context-guru, so authlib (which imports it directly) can't resolve it. This is a cross-repo blocker, not a defect in this PR — as the description notes. The fix belongs inrossoctl/context-guru(rename its module path togithub.com/rossoctl/context-guru, republish), thengo mod tidyin authlib/authbridge-envoy/authbridge-proxy here to regenerate real go.sum checksums. authbridge-envoy/authbridge-proxy pass because they don't import context-guru directly.
Areas reviewed: Go modules (8 go.mod + replace directives), image refs, CI (both failures traced end-to-end), commit conventions.
CI status: 2 failing — verify-pr-title (blocking, fix the title) and Go CI (authlib) (cross-repo context-guru gate); CodeQL/Trivy/Dependency-Review/other Go CI all passing.
mrsabath
pushed a commit
to rossoctl/context-guru
that referenced
this pull request
Jul 20, 2026
…ssoctl/context-guru Part of the Kagenti → Rossoctl rename. context-guru was org-moved to rossoctl/context-guru, but its go.mod still declared module github.com/kagenti/context-guru — a module-path mismatch that blocks downstream importers (cortex's authlib/authbridge-envoy/authbridge-proxy import github.com/rossoctl/context-guru) from running `go mod tidy` / regenerating go.sum. - Go module + imports: github.com/kagenti/context-guru → github.com/rossoctl/context-guru - Cross-repo refs: kagenti/kagenti → rossoctl/rossoctl; kagenti-extensions → cortex (the AuthBridge plugin lives there); kagenti/.github → rossoctl/.github - Brand / prose: Kagenti → Rossoctl Verification: git grep clean of kagenti; go build ✅, go vet ✅, go test ✅ (17 pkgs, 0 fail). Once merged and a new pseudo-version publishes, cortex can `go mod tidy` to pick up the renamed module + real go.sum checksums (rossoctl/cortex#680). Related to rossoctl/rossoctl#1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
Ibrahim2595
changed the title
Contributor
|
The Fix — bump to a post-rename context-guru commit and regenerate go.sum: cd authbridge/authlib && go mod tidy
cd ../cmd/authbridge-envoy && go mod tidy
cd ../authbridge-proxy && go mod tidyThat resolves context-guru at |
context-guru's module path was renamed (rossoctl/context-guru#10, commit 8fc7c7b36563). This branch pinned the pre-rename commit v0.0.0-20260713113308-b624f2c3d8c2 whose go.mod still declared github.com/kagenti/context-guru, breaking `go build`/`go mod verify` with a module-path mismatch (the Go CI (authlib) failure). Bumped context-guru to v0.0.0-20260720181432-8fc7c7b36563 and regenerated real go.sum checksums via `go mod tidy` in authlib, authbridge-envoy, authbridge-proxy. Verification: all 8 modules build; authlib go vet + go test pass (43 pkgs, 0 fail); git grep clean of kagenti and rossocortex. Related to rossoctl/rossoctl#1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
Contributor
Author
|
Done ( Next in the chain: once this merges and a |
mrsabath
approved these changes
Jul 20, 2026
mrsabath
left a comment
mrsabath
left a comment
Contributor
There was a problem hiding this comment.
Re-reviewed — both blockers from my earlier review are resolved:
- Title: now
Refactor: Rename rossocortex → cortex (fix module paths)—verify-pr-titleis green. Go CI (authlib): the context-guru pin was bumpedb624f2c3d8c2→v0.0.0-20260720181432-8fc7c7b36563(the post-rename commit whose go.mod declaresgithub.com/rossoctl/context-guru) viago mod tidy, which also regenerated realgo.sumchecksums. The job now passes.
The rossocortex → cortex module-path rename is faithful and all checks are green. Approving — this supersedes my earlier REQUEST_CHANGES.
After merge, tag v* to publish ghcr.io/rossoctl/cortex/authbridge-* (which unblocks operator #489's E2E). Note: newly-pushed GHCR packages default to private, so set them Public afterward or the anonymous docker pull in E2E will still 403 — see the rollout status on rossoctl/rossoctl#1972.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Rossoctl rename: #678 merged the kagenti→rossoctl content but not the later rossocortex→cortex change. The repo is now
rossoctl/cortex, yet its 8 Go modules still declaregithub.com/rossoctl/rossocortex/...— a module-path mismatch that breaksgo get/imports ofgithub.com/rossoctl/cortex/.... This sweeps allrossocortex → cortex:github.com/rossoctl/rossocortex/...→github.com/rossoctl/cortex/...(+ internalreplacedirectives)ghcr.io/rossoctl/rossocortex/*→ghcr.io/rossoctl/cortex/*Verification
rossocortexandkagentiauthbridge-cpex+ demos build ✅Known cross-repo dependency (not this PR)
authlib/authbridge-envoy/authbridge-proxydepend ongithub.com/rossoctl/context-guru, which is org-moved but not yet module-path-renamed (its go.mod still declaresgithub.com/kagenti/context-guru).go mod tidythere is blocked until context-guru itself is renamed + republished; real go.sum checksums regenerate then.Related issue(s)
Related to #1972