Skip to content

Refactor: Rename rossocortex → cortex (follow-up)#735

Merged
mrsabath merged 1 commit into
rossoctl:mainfrom
Ibrahim2595:fix/rossocortex-to-cortex
Jul 20, 2026
Merged

Refactor: Rename rossocortex → cortex (follow-up)#735
mrsabath merged 1 commit into
rossoctl:mainfrom
Ibrahim2595:fix/rossocortex-to-cortex

Conversation

@Ibrahim2595

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the Kagenti → Rossoctl rename (#733): the extensions repo's final name is cortex (rossoctl/cortex), not rossocortex. Updates the one remaining reference (AuthBridge cross-repo link).

Verification

  • grep clean of rossocortex and kagenti

Related issue(s)

Related to #1972

The extensions repo's final name is `cortex` (rossoctl/cortex), not `rossocortex`.
Updates the remaining reference left after rossoctl#733 merged — the AuthBridge cross-repo
link now points at rossoctl/cortex.

Related to #1972

Assisted-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>

@mrsabath mrsabath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Approving — a correct, minimal follow-up. Updates two AuthBridge cross-repo doc-link comments in mcp/weather_tool/deployment/k8s.yaml from github.com/rossoctl/rossocortex/... to github.com/rossoctl/cortex/.... Both are inside YAML # comments (the functional rossoctl.io/inject: disabled label is untouched), and rossoctl/cortex exists so the link now resolves. Signed-off, CI green, already approved by @esnible.

Heads-up (out of scope for this PR — not blocking)

While verifying the link target I noticed the rossocortex → cortex rename appears incomplete beyond this repo, in code that has already merged:

  • rossoctl/cortex still declares its Go modules as module github.com/rossoctl/rossocortex/authbridge/... (e.g. authbridge/authlib/go.mod).
  • rossoctl/operator's token-broker/go.mod still requires github.com/rossoctl/rossocortex/authbridge/authlib.
  • But github.com/rossoctl/rossocortex returns 404 with no redirect (that repo name never existed — the repo is cortex). So go get on that module path will fail; the module path and the repo name are out of sync.

This PR correctly fixes the one reference in examples; the remaining fix (rename the module path rossocortex → cortex in rossoctl/cortex and update the token-broker require in rossoctl/operator, then go mod tidy) belongs in those two repos. Flagging so it isn't lost — happy to open a tracking issue if useful.

Areas reviewed: YAML/K8s manifest, cross-repo link correctness, CI, commit conventions.
Commits: 1, signed-off ✅. CI: all green.

@Ibrahim2595 Ibrahim2595 changed the title 🌱 Rename rossocortex → cortex (follow-up) Refactor: Rename rossocortex → cortex (follow-up) Jul 20, 2026
@mrsabath
mrsabath merged commit ec17c73 into rossoctl:main Jul 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants