Feat: add MTLSReady condition to AgentRuntime status#461
Merged
Conversation
Implement T006 from the mTLS transport security spec. The controller now evaluates SPIRE availability on each reconcile and sets the MTLSReady condition on AgentRuntime status: - SPIREAvailable (True): spire-agent-socket or svid-output volumes detected in the workload's pod template - SPIREUnavailable (False): mTLS mode is permissive/strict but no SPIRE volumes found; emits a Warning Event with actionable guidance - MTLSDisabled (True): mTLSMode explicitly set to disabled - SPIREAssumed (True): Sandbox workloads where PodSpec is not available; SPIRE injection handled by webhook at pod CREATE MTLSReady=False does NOT block Ready=True — it is informational so operators can track mTLS rollout progress across the fleet. Jira: RHAIENG-4928 Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com> Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
varshaprasad96
force-pushed
the
feat/mtls-ready-condition
branch
from
June 22, 2026 19:46
b8aa171 to
d3cb30e
Compare
pdettori
approved these changes
Jun 23, 2026
pdettori
left a comment
Member
There was a problem hiding this comment.
Clean implementation of the informational MTLSReady condition (T006). Code follows existing controller patterns consistently — accessor, condition API, event emission with nil-check guard.
Verified:
MTLSReady=Falsedoes NOT blockReady=True✓- Sandbox path returns
SPIREAssumedvia nil-podSpec check (not nil-function-pointer) ✓ - RBAC diff is controller-gen consolidation — no permission change (serviceaccounts and services already had identical verbs) ✓
- Warning Event emits actionable guidance ✓
- All 16 CI checks passing ✓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MTLSReadycondition logic to the AgentRuntime reconciler (T006 from mTLS spec)spire-agent-socketorsvid-outputvolumes in the workload's pod templateCondition States
SPIREAvailableSPIREUnavailableMTLSDisableddisabledSPIREAssumedKey Design Decisions
MTLSReady=Falsedoes NOT blockReady=True— it's informational for fleet-wide mTLS rollout trackingTest plan
make test)MTLSReady=True/SPIREAvailableMTLSReady=False/SPIREUnavailable+ Warning EventmTLSMode: disabled→ verifyMTLSReady=True/MTLSDisabledJira: RHAIENG-4928
Spec: specs/003-mtls-transport-security (PR #401)
🤖 Generated with Claude Code