fix(kiro): always attempt token refresh on 401 before checking retry …#124
fix(kiro): always attempt token refresh on 401 before checking retry …#124luispater merged 1 commit intorouter-for-me:mainfrom
Conversation
…count Refactor 401 error handling in both executeWithRetry and executeStreamWithRetry to always attempt token refresh regardless of remaining retry attempts. Previously, token refresh was only attempted when retries remained, which could leave valid refreshed tokens unused. Also add auth directory resolution in RefreshManager.Initialize to properly resolve the base directory path before creating the token repository.
Summary of ChangesHello @gogoing1024, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the Kiro executor's authentication mechanism by modifying its 401 error handling. Previously, token refresh attempts were tied to the remaining retry count, potentially leading to valid refreshed tokens being discarded. The updated logic now guarantees a token refresh attempt on every 401 error, improving resilience. Furthermore, the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the 401 error handling to always attempt a token refresh, even on the last retry attempt. This ensures that a valid refreshed token is persisted for subsequent requests, which is a good improvement. The addition of auth directory resolution in the RefreshManager is also a welcome enhancement for path handling. My main feedback is regarding code duplication in kiro_executor.go, where the 401 handling logic is repeated in two functions. Refactoring this into a shared helper method would improve the code's maintainability.
…count
Refactor 401 error handling in both executeWithRetry and executeStreamWithRetry to always attempt token refresh regardless of remaining retry attempts. Previously, token refresh was only attempted when retries remained, which could leave valid refreshed tokens unused.
Also add auth directory resolution in RefreshManager.Initialize to properly resolve the base directory path before creating the token repository.