Skip to content

Added legacy dep to yaml file#139

Merged
coykwan merged 1 commit into
rsm-hcd:mainfrom
coykwan:legacy-deps
Jul 29, 2022
Merged

Added legacy dep to yaml file#139
coykwan merged 1 commit into
rsm-hcd:mainfrom
coykwan:legacy-deps

Conversation

@coykwan
Copy link
Copy Markdown
Contributor

@coykwan coykwan commented Jul 29, 2022 •
edited by myty
Loading

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

@coykwan coykwan requested review from ab-gb and myty July 29, 2022 19:16
myty
myty approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@myty myty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coykwan coykwan merged commit e4f914b into rsm-hcd:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myty myty myty approved these changes

@ab-gb ab-gb Awaiting requested review from ab-gb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coykwan @myty