Skip to content

Update postpublish script#140

Merged
myty merged 2 commits into
mainfrom
bugfix/fix-post-publish-error
Jul 29, 2022
Merged

Update postpublish script#140
myty merged 2 commits into
mainfrom
bugfix/fix-post-publish-error

Conversation

@myty
Copy link
Copy Markdown
Contributor

@myty myty commented Jul 29, 2022

Also update package version and lock file

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

@myty myty requested review from ab-gb and coykwan July 29, 2022 19:49
@myty myty marked this pull request as ready for review July 29, 2022 19:49
coykwan
coykwan approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@coykwan coykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@myty myty merged commit f33f760 into main Jul 29, 2022
@myty myty deleted the bugfix/fix-post-publish-error branch July 29, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ab-gb ab-gb Awaiting requested review from ab-gb

1 more reviewer

@coykwan coykwan coykwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@myty @coykwan