Skip to content

#38: Fixed issue with select arrow displaying beneath select dropdown.#46

Merged
brandongregoryscott merged 1 commit into
rsm-hcd:masterfrom
ralphmcintyre:master
Sep 9, 2020
Merged

#38: Fixed issue with select arrow displaying beneath select dropdown.#46
brandongregoryscott merged 1 commit into
rsm-hcd:masterfrom
ralphmcintyre:master

Conversation

@ralphmcintyre
Copy link
Copy Markdown

Fixes #38

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • [-] Documentation updated (readme, docs, comments, etc.)
  • [-] Localization: No hard-coded error messages in code files (minimally in string constants)
  • [-] New component and/ or properties? Make sure to update storybook

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2020

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   18.65%   18.65%           
=======================================
  Files          51       51           
  Lines         895      895           
  Branches      208      208           
=======================================
  Hits          167      167           
  Misses        718      718           
  Partials       10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a21c2c...4db2572. Read the comment docs.

@brandongregoryscott
Copy link
Copy Markdown
Contributor

Looks good to me 👍 Thanks for fixing this up, @ralphjmcintyre!

image

@brandongregoryscott brandongregoryscott merged commit 70e5ccf into rsm-hcd:master Sep 9, 2020
@brandongregoryscott
Copy link
Copy Markdown
Contributor

@all-contributors add @ralphjmcintyre for code

@allcontributors
Copy link
Copy Markdown
Contributor

@brandongregoryscott

I've put up a pull request to add @ralphjmcintyre! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Select storybook styles

3 participants