Skip to content

Added tests for unordered list#56

Merged
wintondeshong merged 5 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-molecules-unordered-list
Oct 28, 2020
Merged

Added tests for unordered list#56
wintondeshong merged 5 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-molecules-unordered-list

Conversation

@SaidShah
Copy link
Copy Markdown
Contributor

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

Closes #31

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 26, 2020

Codecov Report

Merging #56 into main will increase coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   20.62%   21.35%   +0.73%     
==========================================
  Files          51       51              
  Lines         897      899       +2     
  Branches      209      209              
==========================================
+ Hits          185      192       +7     
+ Misses        702      697       -5     
  Partials       10       10              
Impacted Files Coverage Δ
src/molecules/lists/unordered-list.tsx 100.00% <100.00%> (+33.33%) ⬆️
src/atoms/forms/radio-button-input.tsx 100.00% <0.00%> (+12.50%) ⬆️
src/atoms/typography/paragraph.tsx 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2368707...4fadecb. Read the comment docs.

@SaidShah SaidShah requested a review from jstevenson October 27, 2020 14:18
@SaidShah
Copy link
Copy Markdown
Contributor Author

@jstevenson I did change it, thank you for the input👍.

Copy link
Copy Markdown
Contributor

@brandongregoryscott brandongregoryscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this (and following PRs to backfill tests) for now, but I'll wait on merging all of them until we decide on whether to pull in @testing-library/jest-dom for the extended matchers.

Comment thread src/molecules/lists/unordered-list.tsx
@brandongregoryscott
Copy link
Copy Markdown
Contributor

Is there a reason for using faker rather than just using a static class name without spaces? This is less readable, is slower, uses more memory, and as your update shows, can be wrong.

While it's not something that really needs to be randomized, as a general rule of thumb, if it doesn't need to be a specific value, I prefer to keep the data randomized - it helps shed light on edge cases that might not be handled and to be honest, we use faker all over the place - not sure we're really concerned about memory usage for unit testing at this scale.

@wintondeshong wintondeshong self-assigned this Oct 28, 2020
@wintondeshong wintondeshong merged commit e77c8b6 into rsm-hcd:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill tests for Molecules/UnorderedList

4 participants