Added tests for unordered list#56
Conversation
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 20.62% 21.35% +0.73%
==========================================
Files 51 51
Lines 897 899 +2
Branches 209 209
==========================================
+ Hits 185 192 +7
+ Misses 702 697 -5
Partials 10 10
Continue to review full report at Codecov.
|
|
@jstevenson I did change it, thank you for the input👍. |
brandongregoryscott
left a comment
There was a problem hiding this comment.
Approving this (and following PRs to backfill tests) for now, but I'll wait on merging all of them until we decide on whether to pull in @testing-library/jest-dom for the extended matchers.
While it's not something that really needs to be randomized, as a general rule of thumb, if it doesn't need to be a specific value, I prefer to keep the data randomized - it helps shed light on edge cases that might not be handled and to be honest, we use faker all over the place - not sure we're really concerned about memory usage for unit testing at this scale. |
Closes #31