Added tests for TextAreaFormField#59
Merged
wintondeshong merged 3 commits intoOct 28, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 20.62% 21.15% +0.53%
==========================================
Files 51 51
Lines 897 898 +1
Branches 209 209
==========================================
+ Hits 185 190 +5
+ Misses 702 701 -1
+ Partials 10 7 -3
Continue to review full report at Codecov.
|
jstevenson
approved these changes
Oct 27, 2020
| import { render } from "@testing-library/react"; | ||
| import { TextAreaFormField } from "./text-area-form-field"; | ||
| import { | ||
| TextAreaFormField, |
| expect(getByText(testErrorMessage)).not.toBeNil(); | ||
| }); | ||
|
|
||
| test("when has errorsMessage prop, renders text area form field with error message", () => { |
There was a problem hiding this comment.
Minor: prop is named errorMessage, not errorsMessage.
| expect(result).not.toBeNil(); | ||
| }); | ||
|
|
||
| test(`when isValid prop is true, renders with out ${InvalidInputClassName} class name`, () => { |
jstevenson
approved these changes
Oct 27, 2020
wintondeshong
suggested changes
Oct 28, 2020
Contributor
wintondeshong
left a comment
wintondeshong
left a comment
There was a problem hiding this comment.
@SaidShah please expound upon the errorMessages prop test below and then we are good to approve
wintondeshong
approved these changes
Oct 28, 2020
Contributor
wintondeshong
left a comment
wintondeshong
left a comment
There was a problem hiding this comment.
@SaidShah thanks for the quick turn around on these changes! Approved 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27