Skip to content

Added tests for checkbox button#61

Merged
wintondeshong merged 3 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-atoms-checkbox-button
Oct 28, 2020
Merged

Added tests for checkbox button#61
wintondeshong merged 3 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-atoms-checkbox-button

Conversation

@SaidShah
Copy link
Copy Markdown
Contributor

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

Closes #5

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2020

Codecov Report

Merging #61 into main will increase coverage by 0.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   20.62%   21.38%   +0.75%     
==========================================
  Files          51       51              
  Lines         897      898       +1     
  Branches      209      209              
==========================================
+ Hits          185      192       +7     
+ Misses        702      696       -6     
  Partials       10       10              
Impacted Files Coverage Δ
src/atoms/forms/checkbox-button.tsx 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d56e16...a0e2ecd. Read the comment docs.

Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaidShah After adding the missing endregion statement should be good to go 👍

Comment thread src/atoms/forms/checkbox-button.tsx
@wintondeshong wintondeshong self-assigned this Oct 28, 2020
@wintondeshong wintondeshong merged commit a76eaa1 into rsm-hcd:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill tests for Atoms/CheckboxButton

3 participants