Skip to content

Added tests for checkbox input#62

Merged
wintondeshong merged 2 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-atoms-checkbox-input
Oct 28, 2020
Merged

Added tests for checkbox input#62
wintondeshong merged 2 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-atoms-checkbox-input

Conversation

@SaidShah
Copy link
Copy Markdown
Contributor

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

Closes #6

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 27, 2020

Codecov Report

Merging #62 into main will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   20.62%   20.73%   +0.11%     
==========================================
  Files          51       51              
  Lines         897      897              
  Branches      209      209              
==========================================
+ Hits          185      186       +1     
+ Misses        702      701       -1     
  Partials       10       10              
Impacted Files Coverage Δ
src/atoms/forms/checkbox-input.tsx 100.00% <100.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d56e16...11b74d0. Read the comment docs.

Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaidShah my feedback was minor so feel free to consider my rename and update the PR. Otherwise, good to go from my perspective.

Comment thread src/atoms/forms/checkbox-input.tsx Outdated
if (disabled) {
className += " -disabled";
}
let isDisabled = disabled ? CheckboxDisabledClass : "";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Recommend renaming from isDisabled to isDisabledClassName or something along those lines. While I realize we are in typescript and it would hopefully catch it, isDisabled strongly suggests to readers it is a boolean.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I will change that 👍

@wintondeshong wintondeshong self-assigned this Oct 28, 2020
@wintondeshong wintondeshong merged commit f0440ff into rsm-hcd:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill tests for Atoms/CheckboxInput

2 participants