Added tests for checkbox input#62
Conversation
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 20.62% 20.73% +0.11%
==========================================
Files 51 51
Lines 897 897
Branches 209 209
==========================================
+ Hits 185 186 +1
+ Misses 702 701 -1
Partials 10 10
Continue to review full report at Codecov.
|
wintondeshong
left a comment
There was a problem hiding this comment.
@SaidShah my feedback was minor so feel free to consider my rename and update the PR. Otherwise, good to go from my perspective.
| if (disabled) { | ||
| className += " -disabled"; | ||
| } | ||
| let isDisabled = disabled ? CheckboxDisabledClass : ""; |
There was a problem hiding this comment.
Suggestion: Recommend renaming from isDisabled to isDisabledClassName or something along those lines. While I realize we are in typescript and it would hopefully catch it, isDisabled strongly suggests to readers it is a boolean.
There was a problem hiding this comment.
Good call, I will change that 👍
Closes #6