Skip to content

Add tests for molecules select form field#63

Merged
wintondeshong merged 5 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-molecules-select-form-field
Oct 28, 2020
Merged

Add tests for molecules select form field#63
wintondeshong merged 5 commits into
rsm-hcd:mainfrom
SaidShah:add-tests-for-molecules-select-form-field

Conversation

@SaidShah
Copy link
Copy Markdown
Contributor

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

Closes #26

Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaidShah once the test of multiple error messages is expounded upon, we are good to go for approval

Comment thread src/molecules/form-fields/select-form-field.test.tsx Outdated
Comment thread src/molecules/form-fields/select-form-field.test.tsx Outdated
Comment thread src/molecules/form-fields/select-form-field.test.tsx Outdated
@wintondeshong wintondeshong self-assigned this Oct 28, 2020
Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaidShah great! thanks for the quick turn around on the revisions. approved 👍

@wintondeshong wintondeshong merged commit d30e8cf into rsm-hcd:main Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backfill tests for Molecules/SelectFormField

2 participants