Skip to content

Removed e.preventDefault() from window object touchEnd event. Added …#67

Merged
wintondeshong merged 1 commit into
rsm-hcd:mainfrom
KevinBusch:issue-66
Oct 29, 2020
Merged

Removed e.preventDefault() from window object touchEnd event. Added …#67
wintondeshong merged 1 commit into
rsm-hcd:mainfrom
KevinBusch:issue-66

Conversation

@KevinBusch
Copy link
Copy Markdown
Collaborator

…comments to other e.preventDefault() to explain the 'why'

#66

  • Related GitHub issue(s) linked in PR description
  • Destination branch merged, built and tested with your changes
  • Code formatted and follows best practices and patterns
  • Code builds cleanly (no additional warnings or errors)
  • Manually tested
  • Automated tests are passing
  • No decreases in automated test coverage
  • Documentation updated (readme, docs, comments, etc.)
  • Localization: No hard-coded error messages in code files (minimally in string constants)
  • New component and/ or properties? Make sure to update storybook

…omments to other e.preventDefault() to explain the 'why'
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2020

Codecov Report

Merging #67 into main will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   25.58%   25.66%   +0.08%     
==========================================
  Files          51       51              
  Lines         903      900       -3     
  Branches      209      209              
==========================================
  Hits          231      231              
+ Misses        665      662       -3     
  Partials        7        7              
Impacted Files Coverage Δ
...forms/canvas-sketch/tools/line-canvas-draw-tool.ts 0.00% <ø> (ø)
...atoms/forms/canvas-sketch/tools/pan-canvas-tool.ts 0.00% <ø> (ø)
...rms/canvas-sketch/tools/pencil-canvas-draw-tool.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc7eda2...8132828. Read the comment docs.

@wintondeshong wintondeshong requested a review from a team October 29, 2020 08:57
Copy link
Copy Markdown
Contributor

@wintondeshong wintondeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @KevinBusch! Thanks for the contribution

@wintondeshong wintondeshong added the enhancement New feature or request label Oct 29, 2020
@wintondeshong wintondeshong merged commit faa6422 into rsm-hcd:main Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants