Add tests for molecules password form field#76
Merged
brandongregoryscott merged 8 commits intoNov 11, 2020
Merged
Conversation
added 7 commits
October 28, 2020 13:56
…cript.React.Components into main
SaidShah
requested review from
brandongregoryscott,
jstevenson and
wintondeshong
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 25.66% 32.33% +6.66%
==========================================
Files 51 51
Lines 900 903 +3
Branches 209 209
==========================================
+ Hits 231 292 +61
+ Misses 662 611 -51
+ Partials 7 0 -7
Continue to review full report at Codecov.
|
brandongregoryscott
suggested changes
Nov 11, 2020
|
|
||
| const [isVisible, setIsVisible] = useState<boolean>(false); | ||
| const cssIsValid = isValid ? "" : "-invalid"; | ||
| const cssIsValid = isValid ? "" : InvalidInputClassName; |
Contributor
There was a problem hiding this comment.
Could this be namespaced to this component so we don't (potentially) have multiple InvalidInputClassName imports? PasswordFormFieldInvalidClassName
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback. I have changed the name if you want to take another look. 👍
brandongregoryscott
approved these changes
Nov 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25