This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Ensure let block is not passed to super call.#827
Merged
myronmarston merged 2 commits intorspec:masterfrom Mar 12, 2013
cupakromer:fix-issue-820
Merged
Ensure let block is not passed to super call.#827myronmarston merged 2 commits intorspec:masterfrom cupakromer:fix-issue-820
myronmarston merged 2 commits intorspec:masterfrom
cupakromer:fix-issue-820
Conversation
Fix #820. This is directly related to bug http://bugs.ruby-lang.org/issues/8059. It seems to affect Ruby 1.9.3 but not Ruby 2.0.0. As per the notes, it is a heisenbug, so simply looking at it causes the bug to disappear. Force the call to super to make sure the let block is not passed in.
Member
|
Thanks, @cupakromer. This looks good. Did you verify that the spec you added for this failed before you added the fix? |
Member
|
Also, if you're up for it, please add an entry to the Changelog ... it saves me having to do that! |
Member
Author
|
Yes, it failed in 1.9.3p392 before the fix to the lib file. I'll add the Changelog entry. |
Member
Author
|
Do you want me to rebase the Changelog into the same commit? |
Member
|
I don't particularly care. |
Member
There was a problem hiding this comment.
Thanks for fixing my typo!
myronmarston
added a commit
that referenced
this pull request
Mar 12, 2013
Ensure let block is not passed to super call.
Member
|
Thanks, @cupakromer! Sorry about the delay on merging it. The travis CI build broke due to the travis VM upgrades and I've spent the last couple days getting it back to green. |
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…sue-820 Ensure let block is not passed to super call. --- This commit was imported from rspec/rspec-core@313dc77.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #820. This is directly related to bug
http://bugs.ruby-lang.org/issues/8059. It seems to affect Ruby 1.9.3
but not Ruby 2.0.0. As per the notes, it is a heisenbug, so simply
looking at it causes the bug to disappear.
Force the call to super to make sure the let block is not passed in.