move connect runtime mount location#896
Open
karawoo wants to merge 2 commits into
Open
Conversation
to avoid masking containerized app content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mounts the Connect runtime at
/opt/rstudio-connect-runtimeinstead of/opt/rstudio-connectand setsconfig.Kubernetes.ConnectRuntimeDirto match, so the content mount and the path Connect looks at can't diverge.The reason for this is that containerized content lives inside the built images at
/opt/rstudio-connect/mnt/appbut with the runtime mounted to/opt/rstudio-connectthat path is obscured and containerized content fails to run.Previous versions of the chart mounted the runtime components at subpaths under
/opt/rsudio-connect(0.8.14 did this for the launcher), but I opted against that to avoid having to maintain separate mounts in the event the runtime directory structure changes.Relocating the app content instead would also be a possibility but would break existing containerized applications that have already put their content at
mnt/app.