Rubocop config file now includes in execution#28
Open
jherrlin wants to merge 1 commit intorubocop:masterfrom
jherrlin:feature/config-file
Open
Rubocop config file now includes in execution#28jherrlin wants to merge 1 commit intorubocop:masterfrom jherrlin:feature/config-file
jherrlin wants to merge 1 commit intorubocop:masterfrom
jherrlin:feature/config-file
Conversation
bbatsov
reviewed
Jun 5, 2018
| :type 'string) | ||
|
|
||
| (defcustom rubocop-config-file-names | ||
| '(".rubycop.yml" ".rubycop" "rubocop.yml" ".rubocop") |
Collaborator
There was a problem hiding this comment.
rubycop? I've never seen such a config file for RuboCop. The only valid name is .rubocop.yml. I should now. :-)
|
Is there any reason why this request doesn't get merged? Is it related to the naming of the rules file mentioned by @bbatsov ? |
Collaborator
|
Yep. |
Collaborator
|
There's also the fact that RuboCop would normally pick up the right configuration file anyways, as we're running it after |
Author
|
Guess that I didn't know that RuboCop picked up the configuration file or if I could not spell the config file name, dont remember. Should I close the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will look for a config file in the project root and include it in the execution if found.