Skip to content

inspect memory limit fix #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valich merged 16 commits into from
Jul 25, 2017
Merged

inspect memory limit fix #100

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d591919
inspect memory limit
viuginick1 Jul 1, 2017
045a84c
cleanup
viuginick1 Jul 1, 2017
5d0ac96
Option to disable memory check is added
viuginick1 Jul 3, 2017
9665253
disable memory limit in the same option
viuginick1 Jul 3, 2017
740c656
cleanup: formating fix, rename variable, rewrite on "compact = if (...)"
viuginick1 Jul 5, 2017
e5d7d57
fixed exeption message
viuginick1 Jul 5, 2017
9a9c981
memory limit logging added
viuginick1 Jul 5, 2017
cc45f3b
debug output deleted
viuginick1 Jul 5, 2017
b15847f
print_msg -> print_debug
viuginick1 Jul 5, 2017
8328947
object_id deleted from the exeption message
viuginick1 Jul 5, 2017
7b3a875
Fixes according to the review
viuginick1 Jul 6, 2017
84f17fd
timelimit for inspect evaluation added
viuginick1 Jul 7, 2017
f7f64a9
The handler is called with a probability of 25%
viuginick1 Jul 7, 2017
57940ab
cleanup
viuginick1 Jul 7, 2017
bc8e07c
inspect_with_alloc_control -> exec_with_... and heuristic break for v…
viuginick1 Jul 18, 2017
0b80618
fixes according to reiew
viuginick1 Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@viuginick1
viuginick1 committed Jul 1, 2017
commit 045a84c31ea3a2dc6f23b58a9ef14e4267f631dc
4 changes: 1 addition & 3 deletions lib/ruby-debug-ide/xml_printer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,8 +404,7 @@ def inspect_with_allocation_control(slice, memory_limit)
trace.disable
rescue MemoryLimitError
return nil
Copy link
Contributor

@valich valich Jul 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it makes sense to add some logging for such cases? Or return something very special

Copy link
Collaborator Author

@viuginick1 viuginick1 Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added logging

Copy link
Contributor

@valich valich Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think printing also a stacktrace of an exception may help investigating the problems in inspect calls for users.

Copy link
Collaborator Author

@viuginick1 viuginick1 Jul 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This backtrack will end with the calls of our debase and r-d-i methods. I think that this is not very useful.

end

end

def compact_array_str(value)
slice = value[0..10]
Expand All @@ -422,7 +421,6 @@ def compact_array_str(value)
compact
end


def compact_hash_str(value)
slice = value.sort_by { |k, _| k.to_s }[0..5]
compact = slice.map { |kv| "#{kv[0]}: #{handle_binary_data(kv[1])}" }.join(", ")
Expand Down