Avoid auth-sanitizer top-level namespaces#360
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how the auth-sanitizer dependency is loaded so require "oauth" no longer introduces top-level Auth / AuthSanitizer constants, keeping the sanitizer integration contained within the OAuth namespace.
Changes:
- Introduces
OAuth::AUTH_SANITIZERvia an internal isolated loader and updates OAuth core classes to includeOAuth::AUTH_SANITIZER::FilteredAttributes. - Adds a spec to assert top-level constants are not defined after requiring
oauth. - Bumps the
auth-sanitizerdependency to>= 0.1.3and updates the gem version/lockfile accordingly.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/oauth/auth_sanitizer_spec.rb | Adds regression coverage to ensure Auth / AuthSanitizer don’t leak into the top-level namespace and verifies mixins are present. |
| sig/oauth/tokens/token.rbs | Updates signatures to include OAuth::AUTH_SANITIZER::FilteredAttributes. |
| sig/oauth/signature/base.rbs | Updates signatures to include OAuth::AUTH_SANITIZER::FilteredAttributes. |
| sig/oauth/consumer.rbs | Updates signatures to include OAuth::AUTH_SANITIZER::FilteredAttributes. |
| oauth.gemspec | Bumps auth-sanitizer dependency minimum version to 0.1.3. |
| lib/oauth/version.rb | Bumps gem version to 1.1.5. |
| lib/oauth/tokens/token.rb | Switches redaction mixin reference to OAuth::AUTH_SANITIZER::FilteredAttributes. |
| lib/oauth/signature/base.rb | Switches redaction mixin reference to OAuth::AUTH_SANITIZER::FilteredAttributes. |
| lib/oauth/consumer.rb | Switches redaction mixin reference to OAuth::AUTH_SANITIZER::FilteredAttributes. |
| lib/oauth/auth_sanitizer.rb | Adds isolated loader that loads auth-sanitizer without defining top-level constants. |
| lib/oauth.rb | Replaces direct auth/sanitizer require with internal loader require. |
| Gemfile.lock | Updates locked versions for oauth + auth-sanitizer. |
| CHANGELOG.md | Documents the isolation change under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing