Skip to content

Avoid unnecessary string duplication in .urlsafe_decode64 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 3 commits into from
Sep 25, 2021
Merged

Avoid unnecessary string duplication in .urlsafe_decode64 #6

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c82ee4
Add Gemfile.lock to .gitgnore
jcmfernandes Sep 24, 2021
37192dc
Out with minitest, in with test-unit
jcmfernandes Sep 24, 2021
6401ef5
Avoid unnecessary string duplication
jcmfernandes Sep 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid unnecessary string duplication 
String#ljust returns a new string, so whenever we need to add
padding, we can replace "-/" in place with String#tr! and avoid creating
yet another copy of the string.
  • Loading branch information
@jcmfernandes
jcmfernandes committed Sep 24, 2021
commit 6401ef58243efa65e0dbbfcddf9610a084b84886
4 changes: 3 additions & 1 deletion lib/base64.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ def urlsafe_decode64(str)
# NOTE: RFC 4648 does say nothing about unpadded input, but says that
# "the excess pad characters MAY also be ignored", so it is inferred that
# unpadded input is also acceptable.
str = str.tr("-_", "+/")
if !str.end_with?("=") && str.length % 4 != 0
str = str.ljust((str.length + 3) & ~3, "=")
str.tr!("-_", "+/")
else
str = str.tr("-_", "+/")
end
strict_decode64(str)
end
Expand Down