Skip to content

Remove double colon in Hash keys (:sym: "value" → sym: "value") #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amomchilov wants to merge 8 commits into
base: master
Choose a base branch
from
+518 −473
Open

Remove double colon in Hash keys (:sym: "value" → sym: "value") #1003

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
734fdc1
Improve existing tests
amomchilov Jan 4, 2024
b4d3f7b
Share variable inspection logic between CDP and DAP
amomchilov Jan 4, 2024
ef9a68b
Inline `variable.rb`
amomchilov Sep 26, 2023
107fd66
Fix edge case for falsy values
amomchilov Jan 4, 2024
005d961
Skip unnecessary values when 0
amomchilov Jan 4, 2024
ccb8669
Fix out-of-bound index access
amomchilov Jan 4, 2024
5286b34
Test for #1001
ono-max Jan 7, 2024
74d6047
Remove colon from Hash key symbols
amomchilov Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix out-of-bound index access
  • Loading branch information
@amomchilov @st0012
amomchilov authored and st0012 committed Dec 18, 2024
commit ccb86691c0d472d018e3e203d67b9ca8db64e6ba
4 changes: 3 additions & 1 deletion lib/debug/variable_inspector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ class VariableInspector
def indexed_members_of(obj, start:, count:)
return [] if start > (obj.length - 1)

(start...(start + count)).map do |i|
capped_count = [count, obj.length - start].min

(start...(start + capped_count)).map do |i|
Variable.new(name: i.to_s, value: obj[i])
end
end
Expand Down
26 changes: 9 additions & 17 deletions test/protocol/hover_raw_dap_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,14 +619,6 @@ def test_hover_works_correctly
variablesReference: 30,
namedVariables: /\d+/
},
{
# This is an extra entry caused by an out-of-bounds index access in server_dap.rb
name: "9",
value: nil,
type: NilClass,
variablesReference: 31,
namedVariables: /\d+/
}
]
}
},
Expand All @@ -649,7 +641,7 @@ def test_hover_works_correctly
message: "Success",
body: {
type: "Integer",
variablesReference: 32,
variablesReference: 31,
namedVariables: /\d+/,
result: "3"
}
Expand All @@ -658,7 +650,7 @@ def test_hover_works_correctly
seq: 23,
command: "variables",
arguments: {
variablesReference: 32
variablesReference: 31
},
type: "request"
},
Expand All @@ -675,7 +667,7 @@ def test_hover_works_correctly
name: "#class",
value: "Integer",
type: "Class",
variablesReference: 33,
variablesReference: 32,
namedVariables: /\d+/
}
]
Expand All @@ -700,7 +692,7 @@ def test_hover_works_correctly
message: "Success",
body: {
type: "Integer",
variablesReference: 34,
variablesReference: 33,
namedVariables: /\d+/,
result: "2"
}
Expand All @@ -709,7 +701,7 @@ def test_hover_works_correctly
seq: 25,
command: "variables",
arguments: {
variablesReference: 34
variablesReference: 33
},
type: "request"
},
Expand All @@ -726,7 +718,7 @@ def test_hover_works_correctly
name: "#class",
value: "Integer",
type: "Class",
variablesReference: 35,
variablesReference: 34,
namedVariables: /\d+/
}
]
Expand All @@ -751,7 +743,7 @@ def test_hover_works_correctly
message: "Success",
body: {
type: "Integer",
variablesReference: 36,
variablesReference: 35,
namedVariables: /\d+/,
result: "1"
}
Expand All @@ -760,7 +752,7 @@ def test_hover_works_correctly
seq: 27,
command: "variables",
arguments: {
variablesReference: 36
variablesReference: 35
},
type: "request"
},
Expand All @@ -777,7 +769,7 @@ def test_hover_works_correctly
name: "#class",
value: "Integer",
type: "Class",
variablesReference: 37,
variablesReference: 36,
namedVariables: /\d+/
}
]
Expand Down