Skip to content

Fix one of flakey test in protocol tests #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ono-max wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix one of flakey test in protocol tests #1060

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
89aded5
Fix one of flakey test in protocol tests
ono-max Jan 7, 2024
01bef21
Update lib/debug/server_cdp.rb
ono-max Jan 8, 2024
af9ef5c
Use quit! command instead of kill! command
ono-max Jan 29, 2024
d5f6497
debug
ono-max Jan 29, 2024
ecebe71
fix
ono-max Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/debug/server_cdp.rb 
Co-authored-by: Stan Lo <stan001212@gmail.com>
  • Loading branch information
@ono-max @st0012
ono-max and st0012 committed Jan 29, 2024
commit 01bef21062189f97c678798bc560639e81a72992
8 changes: 2 additions & 6 deletions lib/debug/server_cdp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,12 +489,8 @@ def process
id: SecureRandom.hex
when 'Runtime.terminateExecution'
send_response req
if SESSION.in_subsession?
@q_msg << 'kill!'
else
@q_msg << 'kill!'
pause
end
@q_msg << 'kill!'
pause unless SESSION.in_subsession?
when 'Page.startScreencast', 'Emulation.setTouchEmulationEnabled', 'Emulation.setEmitTouchEventsForMouse',
'Runtime.compileScript', 'Page.getResourceContent', 'Overlay.setPausedInDebuggerMessage',
'Runtime.releaseObjectGroup', 'Runtime.discardConsoleEntries', 'Log.clear', 'Runtime.runIfWaitingForDebugger'
Expand Down