Skip to content

CI: Add "3.0" to matrix, and bump gem version to "3.0.1.pre" to differentiate from built-in#17

Merged
mrkn merged 4 commits intoruby:masterfrom
olleolleolle:patch-2
Apr 12, 2021
Merged

CI: Add "3.0" to matrix, and bump gem version to "3.0.1.pre" to differentiate from built-in#17
mrkn merged 4 commits intoruby:masterfrom
olleolleolle:patch-2

Conversation

@olleolleolle
Copy link
Copy Markdown
Contributor

No description provided.

@MSP-Greg
Copy link
Copy Markdown
Contributor

MSP-Greg commented Apr 1, 2021

Re the Ruby (Windows) master failures, if I change the version here to 3.1.0 or 3.0.1.pre, it builds and installs (using pkg/*.gem) fine.

Seems like a RubyGems issue? If I install digest, it acts like it's installing digest:3.0.0, but it doesn't do anything, as the version matches the default gem... Not sure...

Maybe a Ubuntu master/head build should be added to CI also?

@olleolleolle
Copy link
Copy Markdown
Contributor Author

@MSP-Greg 👋 Good idea, I added a Ubuntu20+head as an extra element.

@MSP-Greg
Copy link
Copy Markdown
Contributor

MSP-Greg commented Apr 1, 2021

@olleolleolle

Thanks. I knew it was not a Windows issue, but a Ruby master/head issue. People tend to always assume Windows issues are OS specific. The 'debug' builds are master/head builds.

So, the solution (for now) might be to increment the version?

@olleolleolle
Copy link
Copy Markdown
Contributor Author

@MSP-Greg Do you mean "increment the version of this gem"?

@MSP-Greg
Copy link
Copy Markdown
Contributor

MSP-Greg commented Apr 1, 2021

@olleolleolle

Do you mean "increment the version of this gem"?

Yes.

Sorry, too much multi tasking this morning... I think the issue that's confusing RubyGems is that with Ruby master/head, the default digest gem is also version 3.0.0?

This is a test, to see if the build failures are about the shipped Ruby master version of this gem.
@olleolleolle
Copy link
Copy Markdown
Contributor Author

@MSP-Greg In order to test that assumption, I made a change to the version directive in the gemspec of this gem, now, in this PR, to see if there is any change in results in the matrix.

This makes it slightly more explicit that this is not a definite new version.
@olleolleolle olleolleolle changed the title CI: Add "3.0" to matrix CI: Add "3.0" to matrix, and bump gem version to "3.0.1.pre" to differentiate from built-in Apr 6, 2021
@olleolleolle olleolleolle requested a review from mrkn April 12, 2021 08:24
Copy link
Copy Markdown
Member

@mrkn mrkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good to me.

@mrkn mrkn merged commit 8ce3289 into ruby:master Apr 12, 2021
@olleolleolle olleolleolle deleted the patch-2 branch April 12, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants