Skip to content

Fix wrong certificate version #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 1 commit into from
Oct 3, 2024
Merged

Fix wrong certificate version #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/drb/ssl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def setup_certificate
}

cert = OpenSSL::X509::Certificate.new
cert.version = 3
cert.version = 2
Copy link
Copy Markdown
Contributor

@lilole lilole Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch @jeremyevans but I'm afraid someone will come along and break this later.
A tiny comment like # This means v3 would be super valuable.

Copy link
Copy Markdown
Contributor Author

@jeremyevans jeremyevans Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would assume someone changing something like this would use git blame to look at the history, but I agree that a comment would make things easier. As this has already been merged, can you submit a pull request to add the comment?

Copy link
Copy Markdown
Contributor

@lilole lilole Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to do it. Cheers.

cert.serial = 0
name = OpenSSL::X509::Name.new(self[:SSLCertName])
cert.subject = name
Expand Down