Reapply "Remove safe_level and further positional arguments (#7)"#95
Merged
k0kubun merged 1 commit intoruby:masterfrom Nov 12, 2025
Merged
Reapply "Remove safe_level and further positional arguments (#7)"#95k0kubun merged 1 commit intoruby:masterfrom
k0kubun merged 1 commit intoruby:masterfrom
Conversation
This reverts commit 1c02d23.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 12, 2025
arguments (ruby/erb#7)" (ruby/erb#95) This reverts commit ruby/erb@1c02d23dc618. ruby/erb@4162a24ecc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 1c02d23.
Since we're cutting a Ruby 4.0 release, it's a good opportunity to revisit it. It's been deprecated for 7 years since Ruby 2.6. You should be able to install an older erb if an older sprockets doesn't work, anyway.
References
ERB.versionchange was released at 3.1 and it's obviously new, I'll skip this removal in 3.2 and postpone this to a future version.