Open
Conversation
RuhmUndAnsehen
force-pushed
the
leave_argv_alone
branch
3 times, most recently
from
642f432 to
94f4c8f
Compare
Open
RuhmUndAnsehen
force-pushed
the
leave_argv_alone
branch
from
94f4c8f to
7859c5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instances of GetoptLong reference the global constants
ARGVandENV, happily modifying the first one.This seems to defeat the purpose of OOP and makes testing changes harder. This PR gives the programmer the option to explicitly pass a custom
argvandenv.