Open
Conversation
It now fits vertically on my screen as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetoptLong#set_optionsis very long and I also found it hard to read, so I took the liberty of modernizing the code.API changes
First things first, the second commit in the PR contains a minor API change: Option lists now may be any iterable, not just arrays. This required changing the error message and the respective test case.
Description
Previously, sanitation checks and modifications of instance variables happened interchangeably. This required a cleanup step if errors occured.
Now, as a first step, the options list gets partitioned in flags and option names. This allowed me to put the validations first and process the entries later, and to drop the cleanup section. Partitioning also superseded the need to check if
canonical_namewasnilat the end.