✨🐛 Update BODYSTRUCTURE parser; add location; fix bugs#113
Merged
Conversation
✨ Add missing "location" extension data. This was missing from RFC2060 but part of RFC3501. It was also missing from Net::IMAP... until now! 😄 🐛 Fix many bugs. Most importantly: * More strict about where NIL is allowed, e.g: `number`, `envelope`, and `body`. Ignoring these rare server bugs made it difficult to workaround much more common server bugs elsewhere. * BodyTypeAttachment and BodyTypeExtension won't be returned any more and the constants have been deprecated. * Better workaround for multipart parts with... zero parts. 🚧 TODO: Although this will parse *most* strange BODYSTRUCTURE msg-att found in the wild, a future PR will backtrack on parse errors and try one or more "fool-proof" algorithms that partially parse *nearly* all invalid body structures sent by buggy servers... even in pathological cases, such as when servers send the message-id as a quoted string containing unescaped quotation marks! ♻️ Add lookahead and peek methods to def_char_matchers, and peek_str?, peek_re, for matching without consuming and using MatchData. ♻️ rename case_insensitive__string to match new parser style. ♻️ add number64 aliases. (size is unenforced)
This was referenced Feb 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
n.b. this was split off from #104 as its own PR.
✨ Add missing "location" extension data.
This was missing from RFC2060 but part of RFC3501. It was also missing from Net::IMAP... until now! 😄
🐛 Fix several bugs. Most importantly:
NILis not allowed, e.g:number,envelope, andbody. Ignoring these uncommon bugs made it difficult to workaround much more common server bugs elsewhere.BodyTypeAttachmentandBodyTypeExtensionwon't be returned any more and the constants have been deprecated.🚧 TODO: Although this will parse most strange BODYSTRUCTURE msg-att found in the wild, a future PR will backtrack on parse errors and try one or more "fool-proof" algorithms that partially parse nearly all invalid body structures sent by buggy servers... even in pathological cases, such as when servers send the message-id as a quoted string containing unescaped quotation marks!