Merged
Conversation
Until this change, creating an Address would disregard its own parameters if the first parameter was an Address.
"SMTPUTF8" was used as a standin for "an extension the server does not support", which did no harm since the test server definitely didn't insert that, but confused me for a moment, so this commit changes the name of the unsupported extension to DOES-NOT-EXIST.
SMTPUTF8 requires a parameter on the MAIL FROM command if either the sender address or any of the recipient addresses require SMTPUTF8. send_message detects the need for SMTPUTF8 and uses the right parameter when calling mailfrom. Users who call mailfrom and rcptto themselves must detect the need for SMTPUTF8 themselves (or else Net::SMTP will act as if SMTPUTF8 were not required by the message).
Contributor
Author
|
Hi, have you looked at this PR? net-imap now has excellent UTF8=ACCEPT support, so this is the final piece of the puzzle. If there's anything I could do better or should do differently, let me know. |
Contributor
Author
|
Great. Thanks! If I tell you that I'm happy that you did it so quickly, you'll probably think I'm being snide. I am happy, though, not snide. That was faster than average and much faster than some I've experienced, so thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this adds support for SMTPUTF8. The new support is mostly automatic; if send_message detects that sending a message would not work without SMTPUTF8, then it uses SMTPUTF8. And only then.