Skip to content

[rbs diff] Load dependencies from manifest.yaml#1602

Merged
soutaro merged 1 commit into
ruby:masterfrom
ksss:diff-manifest-yaml
Nov 9, 2023
Merged

[rbs diff] Load dependencies from manifest.yaml#1602
soutaro merged 1 commit into
ruby:masterfrom
ksss:diff-manifest-yaml

Conversation

@ksss
Copy link
Copy Markdown
Collaborator

@ksss ksss commented Nov 8, 2023

The rbs diff command selects the environment to compare, but since manifest.yml is not read, there are cases where name resolution is not possible.

Fixed to read manifest.yml.

@ksss ksss changed the title Load dependencies from manifest.yaml [rbs diff] Load dependencies from manifest.yaml Nov 8, 2023
Copy link
Copy Markdown
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@soutaro soutaro added this to the RBS 3.3 milestone Nov 9, 2023
@soutaro soutaro added this pull request to the merge queue Nov 9, 2023
Merged via the queue into ruby:master with commit cc9e876 Nov 9, 2023
@ksss ksss deleted the diff-manifest-yaml branch November 9, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants