Skip to content

Clarify deprecation state of --silent option of rbs validate#1733

Merged
pocke merged 2 commits intoruby:masterfrom
pocke:Clarify_deprecation_state_of____silent__option_of__rbs_validate_
May 28, 2024
Merged

Clarify deprecation state of --silent option of rbs validate#1733
pocke merged 2 commits intoruby:masterfrom
pocke:Clarify_deprecation_state_of____silent__option_of__rbs_validate_

Conversation

@pocke
Copy link
Copy Markdown
Member

@pocke pocke commented Jan 24, 2024

Currently --silent option just displays "`--silent` option is deprecated." . The user cannot decide what they should do from this message. So I updated the message to describe that the silent mode is default and they can use --log-level option also.

ref: #1648

cc/@ksss

Currently `--silent` option just displays ``"`--silent` option is deprecated." ``. The user cannot decide what they should do from this message.
So I updated the message to describe that the silent mode is default and they can use `--log-level` option also.
@pocke pocke force-pushed the Clarify_deprecation_state_of____silent__option_of__rbs_validate_ branch from d1e1b06 to f0d1837 Compare January 24, 2024 06:09
Copy link
Copy Markdown
Collaborator

@ksss ksss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pocke pocke added this pull request to the merge queue May 28, 2024
Merged via the queue into ruby:master with commit 3cc10c5 May 28, 2024
@pocke pocke deleted the Clarify_deprecation_state_of____silent__option_of__rbs_validate_ branch May 28, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants