Use cast for converting source start pointer to c_char#2914
Merged
soutaro merged 1 commit intoruby:masterfrom Apr 2, 2026
Merged
Use cast for converting source start pointer to c_char#2914soutaro merged 1 commit intoruby:masterfrom
soutaro merged 1 commit intoruby:masterfrom
Conversation
Edouard-chin
added a commit
to Shopify/rubydex
that referenced
this pull request
Apr 3, 2026
- cibuildgem supports building binary by any runners supported on GitHub. I originally didn't include this platform as I wasnt sure whether users would want a precompiled binary for linux aarch64. A user asked for it so let's add it to the matrix #714 I tested and it compiles correctly https://github.com/Shopify/rubydex/actions/runs/23947658226/job/69847719701 Though it compiles correctly since the latest release of ruby-rbs 0.3.0 thanks to thix fix ruby/rbs#2914
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context in Shopify/rubydex#714
We're getting a discrepancy between the cast type for the
start_ptrvs the expected types created by cbindgen on aarch64 linux. Based on what I could gather, usingcastinstead ofasguarantees that the type will match (sincerbs_string_newaccepts a*c_char).