Merged
Conversation
|
@robotblake would you be able to explain how this improved the performance? As a generally curious programmer and seeing the dependabot updates on my projects, I'm sure other devs will be coming here to learn about the improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change speeds up UUID generation by somewhere between 10-40%. Originally implemented as part of https://github.com/robotblake/hakusho.
Benchmark Methodology
First install the
benchmark-ipsgem and then create a file calledbenchmark.rbin the root of the repo with the following content.Checkout the
v0.2.0tag, and runruby benchmark.rb.Checkout the
b587b8ccommit, and runruby benchmark.rb.Benchmark Results