Restore SecureRandom.alphanumeric with 0.3.x behavior#36
Merged
Conversation
hsbt
force-pushed
the
restore-alphanumeric-method
branch
from
18f4649 to
2c8cdfb
Compare
Contributor
|
@hsbt Oops, I never made an issue for #34 (comment), so I guess the loss of |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Jan 6, 2026
This commit removes Ruby < 3.3 compatibility code since Rails main branch requires Ruby 3.3. - No need to check `SecureRandom.method(:alphanumeric).parameters.size` in Ruby 3.3+ because it is always 2 ruby/securerandom#36 - Ruby 3.3 introduces `Range#overlap?` https://bugs.ruby-lang.org/issues/19839 - Ruby 3.3 introcuces `Fiber#kill` https://bugs.ruby-lang.org/issues/595 Refer to rails#56511
4 tasks
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Jan 6, 2026
This commit removes Ruby < 3.3 compatibility code since Rails main branch requires Ruby 3.3. - No need to check `SecureRandom.method(:alphanumeric).parameters.size` in Ruby 3.3+ because it is always 2 ruby/securerandom#36 - Ruby 3.3 introduces `Range#overlap?` https://bugs.ruby-lang.org/issues/19839 - Ruby 3.3 introcuces `Fiber#kill` https://bugs.ruby-lang.org/issues/595 Refer to rails#56511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35