Skip to content

Test all virtual environments, not just the latest, and added crontab #60

Merged
eregon merged 5 commits into
ruby:masterfrom
jwillemsen:jwi-testallvariants
Jun 11, 2020
Merged

Test all virtual environments, not just the latest, and added crontab #60
eregon merged 5 commits into
ruby:masterfrom
jwillemsen:jwi-testallvariants

Conversation

@jwillemsen
Copy link
Copy Markdown
Contributor

No description provided.

@jwillemsen
Copy link
Copy Markdown
Contributor Author

Looks on windows-2016 jruby-9.1/jruby/jruby-head/mswin are all failing, are these known failures which I should exclude?

@jwillemsen
Copy link
Copy Markdown
Contributor Author

jruby seems to fail because tar doesn't seem to be on the expected place on windows-2016 and mswin assumes Visual Studio 2019 which is not there on windows-2016

@MSP-Greg
Copy link
Copy Markdown
Collaborator

MSP-Greg commented Jun 9, 2020

Thanks.

The problem is that a native tar.exe exists in Windows 2019, but not Windows 2016. Maybe you can experiment in your fork, as the Git or MSYS2 version may work. I can look at it later...

The mswin build is done using VS 2019, I don't think there have been any requests for a VS 2016 build. It's not a common platform, as there are some extension gems that will not compile with MSVC...

@jwillemsen
Copy link
Copy Markdown
Contributor Author

I have updated the test.yml with the updated platforms so that all should work. My first priority is to update all our actions to use this action, maybe someone else can fix jruby on windows-2016 and enable that in the test.yml again

Comment thread .github/workflows/test.yml
@eregon
Copy link
Copy Markdown
Member

eregon commented Jun 9, 2020

FWIW It was intentional to run a subset of platforms so the CI is reasonably fast and we don't create so many jobs. 74 jobs is still probably somewhat reasonable (but will result in a lot of queuing), so I'm OK to try with this PR and see how it goes.

Note that testing all Ruby versions on all platforms would result in hundreds of jobs and so is completely unrealistic. I don't think it's needed nor very useful either, so the proposed matrix in this PR seems OK.

@eregon
Copy link
Copy Markdown
Member

eregon commented Jun 10, 2020

Could you rebase this?
Most Rubies should work on windows 2016 now, except mswin: #62 (comment)

Comment thread .github/workflows/test.yml Outdated
- { os: windows-2016, ruby: truffleruby-head }
- { os: windows-2016, ruby: jruby }
- { os: windows-2016, ruby: jruby-9.1 }
- { os: windows-2016, ruby: jruby-head }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 3 lines above can be removed now that #61 is fixed

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

…pendencies break this

    * .github/workflows/test.yml:
    * .github/workflows/test.yml:
    * .github/workflows/test.yml:
    * .github/workflows/test.yml:
@jwillemsen jwillemsen force-pushed the jwi-testallvariants branch from b345f58 to e7bbc79 Compare June 11, 2020 06:17
Copy link
Copy Markdown
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit a43803c into ruby:master Jun 11, 2020
@jwillemsen jwillemsen deleted the jwi-testallvariants branch June 11, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants