Default to running the event loop on the main thread#28
Merged
Conversation
This provides a massive speedup. From the sound of this, you would think this would cause blocking of the user interface while the Ruby code runs. However, that happens regardless of this setting, so I'm not sure what advantages there are to running the eventloop on a separate thread. Fixes ruby#26
Collaborator
Author
|
I plan to commit this next week unless I hear objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a massive speedup. From the sound of this, you would
think this would cause blocking of the user interface while the
Ruby code runs. However, that happens regardless of this setting,
so I'm not sure what advantages there are to running the eventloop
on a separate thread.
Fixes #26