Small tweaks for easier vendoring#3
Merged
hsbt merged 1 commit intoruby:masterfrom Apr 18, 2022
deivid-rodriguez:tweaks-for-easier-vendoring
Merged
Small tweaks for easier vendoring#3hsbt merged 1 commit intoruby:masterfrom deivid-rodriguez:tweaks-for-easier-vendoring
hsbt merged 1 commit intoruby:masterfrom
deivid-rodriguez:tweaks-for-easier-vendoring
Conversation
Bundler vendors this file and we have some tools to automatically prepend the `Bundler::` namespace so that the vendored version does not collide with the stdlib version. However, due to how methods are defined, it's hard for our vendoring tool to do the right thing. I think this makes the code simpler and things easier for us too.
Member
|
@deivid-rodriguez It's reasonable. Thanks. |
Member
|
Why don't replace |
Contributor
Author
|
Thank you! @nobu This patch was enough for our vendoring tool to just work, since previously it would change the code to things like But... also I think using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundler vendors this file and we have some tools to automatically prepend the
Bundler::namespace so that the vendored version does not collide with the stdlib version.However, due to how methods are defined, it's hard for our vendoring tool to do the right thing.
I think this makes the code simpler and things easier for us too.