Refactor mkmf with safe navigation operator and split with block#4
Open
Maumagnaguagno wants to merge 2 commits intoruby:masterfrom
Open
Refactor mkmf with safe navigation operator and split with block#4Maumagnaguagno wants to merge 2 commits intoruby:masterfrom
Maumagnaguagno wants to merge 2 commits intoruby:masterfrom
Conversation
With safe navigation operator (Ruby 2.3) and split with block (Ruby 2.6) it is possible to avoid the intermediate variable ``opt``and array created by split, resulting in a more compact and clear code for the mkmf method.
Author
|
I just noticed that the un.gemspec contains Ruby version Should I open a new PR to update to Ruby 2.5 to fix this first, or could the current PR with an updated Gemspec to Ruby 2.6 be enough? |
Author
|
irb just dropped Ruby 2.5 support, ruby/irb#383, while un still uses 2.3 in the un.gemspec, despite using new Ruby 2.5 String methods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With safe navigation operator (Ruby 2.3) and split with block (Ruby 2.6) it is possible to avoid the intermediate variable
optand array created by split, resulting in a more compact and clear code for the mkmf method.