Skip to content

Make PStore support as optional#28

Merged
hsbt merged 1 commit intomasterfrom
optional-pstore
Jan 31, 2024
Merged

Make PStore support as optional#28
hsbt merged 1 commit intomasterfrom
optional-pstore

Conversation

@hsbt
Copy link
Copy Markdown
Member

@hsbt hsbt commented Jan 31, 2024

I have a plan to make PStore to bundled gems. This means Ruby 3.5 will not have pstore library with some environment or platform.

We should make YAML::PStore as optional.

@hsbt hsbt merged commit 285fda7 into master Jan 31, 2024
@hsbt hsbt deleted the optional-pstore branch January 31, 2024 05:56
@Earlopain
Copy link
Copy Markdown

Would this not warn anyways? The logging gem for example requires syslog in rescue like in this PR but even though the functionality is optional it still logs the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants