Add JRuby-specific warning when psych fails#7
Merged
hsbt merged 1 commit intoruby:masterfrom Jan 27, 2022
Merged
Conversation
The error here is confusing for users because JRuby does not use libyaml and installing it will not help. Instead, JRuby directs them to a wiki page that describes an issue when multiple conflicting versions of SnakeYAML are installed. This change allows us to use the yaml gem and delete our local sources.
Contributor
Author
|
This is a noncritical update to add a JRuby version of the psych load warning, since JRuby does not use libyaml and installing it will not fix an issue loading our psych extension. This could possibly be reduced back to a single warning if references to libyaml were removed and we added a link to some informational page. We can use the gem as-is but would prefer to incorporate a better warning for JRuby, so as not to confuse users. |
Contributor
Author
|
Thank you! We are now using yaml gem on JRuby master (9.4, equivalent to 3.1) but when this patch gets into a new release just let me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error here is confusing for users because JRuby does not use
libyaml and installing it will not help. Instead, JRuby directs
them to a wiki page that describes an issue when multiple
conflicting versions of SnakeYAML are installed.
This change allows us to use the yaml gem and delete our local
sources.