config.gemspec: use funding_url rather than post_install_message#360
Merged
pkuczynski merged 1 commit intorubyconfig:masterfrom May 28, 2024
pda:gemspec-funding-uri
Merged
config.gemspec: use funding_url rather than post_install_message#360pkuczynski merged 1 commit intorubyconfig:masterfrom pda:gemspec-funding-uri
funding_url rather than post_install_message#360pkuczynski merged 1 commit intorubyconfig:masterfrom
pda:gemspec-funding-uri
Conversation
Member
|
Yeah, make sense @pda, thanks! |
pkuczynski
approved these changes
May 28, 2024
Member
|
Released as 5.5.0 |
Contributor
Author
|
Thanks very much @pkuczynski 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋🏼
This is a friendly PR to shift the request for funding from the general-purpose
post_install_messageto the specificfunding_urisystem supported by bundler 2.2+.I think this is more in line with etiquette of the community. To quantify that with some anecdata, the main Rails app I work on has ~340 gem dependencies, and I took the time to do a clean install and observe the
post_install_messages. There's 8 in total:configRelated:
— https://bundler.io/blog/2020/12/09/bundler-v2-2.html
— https://guides.rubygems.org/specification-reference/
Thanks! 🙏🏼