add test for workshopLog submission #755
Merged
+98
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
requested changes
Jan 22, 2026
Collaborator
jmilljr24
left a comment
jmilljr24
left a comment
There was a problem hiding this comment.
@diti0-dot Just a couple comments. The rest looks good!
| create(:workshop, title: 'The best workshop in the world', windows_type: adult_window, featured: true) | ||
| create(:workshop, title: 'The best workshop on mars', windows_type: adult_window, featured: true) | ||
|
|
||
| @project = Project.first || create(:project, name: "Test Project", windows_type_id: @windows_type.id) |
Collaborator
There was a problem hiding this comment.
Is there a reason to have the or in this?
Collaborator
There was a problem hiding this comment.
@diti0-dot This is just a nit, but I don't see the benefit of checking for the first record. I'd rather stick with just creating the record you need.
Contributor
Author
There was a problem hiding this comment.
removed the OR operator as suggested.
jmilljr24
approved these changes
Jan 23, 2026
Collaborator
jmilljr24
left a comment
jmilljr24
left a comment
There was a problem hiding this comment.
@diti0-dot Wonderful!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
To add a system test that verifies facilitators can successfully submit workshop logs with all required fields.
How did you approach the change?
Created projects and associated them with the current logged-in facilitator via ProjectUser so the project field is selected by default, then tested each form section as specified.
Anything else to add?
Let me know if anything is missing from the test coverage or requirements.