Create hearing types per organization#1000
Conversation
compwron
left a comment
There was a problem hiding this comment.
This is looking very promising!
- Please add another test for the data showing on the UI
- Please fix the CI build :)
Feel free to drop in to chat in slack #casa https://rubyforgood.herokuapp.com/ for a faster response to questions :)
|
These tests seem to be working locally for me, however some of the system ones seem to be somewhat flaky. Is there a way to retry CI without pushing up a change? @compwron thanks for the feedback, I have added some specs. @Zrrrpy looking forward to hearing your feedback here if you're happy with the approach, and what route you want to take regarding the seed data. If there is no conclusive answer yet, we could always add a backlog item and fill these in when we have better information. When this has been approved and merged I'll make a start on #927 |
|
@haydenrou the flaky build should be fixed now! You can usually re-run the build by clicking on the build and clicking re-run but I don't see the button right now. O.o Pushing a new change (or a rebase to master) will work. |
|
it's a pain to rebase/merge master when you're working on a fork instead of a branch. I moved your code to a branch but didn't open the PR- click here to open a new PR with all the code from this PR (plus a merge of master) so that you can get the hacktoberfest opening-PR credit :) https://github.com/rubyforgood/casa/compare/create-hearing-types?expand=1 Here are instructions on fetching from upstream in case you would prefer to do that :) https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/syncing-a-fork |
|
Very cool! Sorry for the delay on merging this. Yes, seeding for hearing types would be great! For now only in dev/qa/staging, not in production. Be wary of the current discussion in slack about how we will change/combine/parameterize the seed files |
This is my first attempt to hit the acceptance criteria for the attached issue. Please let me know if it falls short at any point.
Before this is ready to merge I had two questions:
I plan on submitting a separate PR for #927 but wanted to get this first iteration out beforehand.
What github issue is this PR for, if any?
Resolves #928
What changed, and why?
There is now a crud(except delete) for hearing types accessible via the casa org edit page. Hearing types can be flagged as active or inactive.
How is this tested? (please write tests!) 💖💪
Via the edit org page, you can add a new hearing type or press the pencil to edit the hearing type.
Screenshots please :)