Past court dates #805#1179
Merged
Merged
Conversation
| cd.destroy! | ||
| end | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
@matisnape we are using After Party for one-time data population tasks. After party tasks run after the data migrations run.
Collaborator
Author
There was a problem hiding this comment.
Yeah, I've seen it. I started with what I know and build up from there :)
And looking at the PR you linked, there won't be a need for populating the db :)
compwron
approved these changes
Oct 26, 2020
compwron
left a comment
compwron
left a comment
Collaborator
There was a problem hiding this comment.
This looks good! ✨💖
Please fix the merge conflict in schema.rb and then we'll merge :)
Collaborator
|
@matisnape I would love to merge this. Do you want help with the merge conflict? |
Collaborator
|
I am going to merge this and then deal with it because dealing with forks is a pain |
Merged
Collaborator
|
✨💖🙌🏼🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #805
What changed, and why?
When court date passes, a past court date is created.
Past court dates are displayed on Edit Casa Case page
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
I would need advice which tests should I add
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
