Skip to content

1064 non transition case court report#1471

Merged
compwron merged 9 commits into
rubyforgood:mainfrom
erik-trantt:1064-non-transition-case-court-report
Dec 15, 2020
Merged

1064 non transition case court report#1471
compwron merged 9 commits into
rubyforgood:mainfrom
erik-trantt:1064-non-transition-case-court-report

Conversation

@erik-trantt

Copy link
Copy Markdown
Collaborator

What github issue is this PR for, if any?

Resolves #1064

What changed, and why?

For the Word template for non-transition aged youth

  • Added sections' guidance as specified in the issue

For UI:

  • Enabled ability to select non-transitioned cases on 'Case Number' dropdown list
  • removed small text notifying users on the generating reports for non-transitioned cases because it has now been implemented

For tests:

  • spec/models/case_court_report_spec.rb: add 1 File.delete() to remove persistent tmp/test_report.docx
  • spec/system/case_court_reports/index_spec.rb: consolidated 2 tests for 'Case Number' dropdown list

How will this affect user permissions?

N/A

How is this tested? (please write tests!) 💖💪

Added 1 test to check the label of selected option in the 'CASA Case' dropdown list. It should show <#case_number> - non-transition
The logic of how users generate & download reports remains the same for transitioned & non-transitioned cases, so I didn't add more tests for non-transitioned cases.

Screenshots please :)

image

image

image

Sample report

CINA-13-1002 org1MM.docx

@erik-trantt erik-trantt marked this pull request as ready for review December 15, 2020 03:56
@compwron

Copy link
Copy Markdown
Collaborator

Very cool!! :)

@compwron compwron merged commit 36d1ee8 into rubyforgood:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Touches Ruby code 🧪 Tests Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

volunteers can generate court reports for non transition aged youth

2 participants