Moves case contacts layout from table based view to card based view#1485
Merged
compwron merged 4 commits intoDec 15, 2020
Conversation
Co-authored-by: Robin Sund <rsund@merchantsbonding.com>
Co-authored-by: Robin Sund <rsund@merchantsbonding.com>
github-actions
Bot
added
ruby
Co-authored-by: Robin Sund <rsund@merchantsbonding.com>
systemnate
changed the title
compwron
approved these changes
Dec 15, 2020
compwron
left a comment
compwron
left a comment
Collaborator
There was a problem hiding this comment.
looking GOOD!
We'll do a trial staging deploy on Weds evening and check prod data for potential cleanup then also, before the friday deploy
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #735 (#735 appeared to have 2 parts - one to convert the view into a card-view and one to move it into tabs. We were able to get the view converted into using cards but ran out of time for the tab part. I may submit a future PR to do this).
What changed, and why?
This changes the case contact index page from a table-view to a card-view.
How will this affect user permissions?
This should not affect any user permissions.
How is this tested? (please write tests!) 💖💪
We have a variety of unit and system tests that cover this new functionality.
Screenshots please :)
This was based on this mockup:
Feelings gif (optional)