Skip to content

Adds edit volunteer page for admins#216

Merged
compwron merged 2 commits into
rubyforgood:masterfrom
colinsoleim:issue-5-edit-volunteer-page
Apr 28, 2020
Merged

Adds edit volunteer page for admins#216
compwron merged 2 commits into
rubyforgood:masterfrom
colinsoleim:issue-5-edit-volunteer-page

Conversation

@colinsoleim
Copy link
Copy Markdown
Collaborator

@colinsoleim colinsoleim commented Apr 28, 2020

What github issue is this PR for, if any?

Resolves #5
Resolved #203

Checklist

  • I have performed a self-review of my own code
  • I added comments, particularly in hard-to-understand areas
  • I updated the /docs
  • I added tests that prove my fix is effective or that my feature works
  • bundle exec rake passes locally
  • My PR title includes "WIP" or is draft PR if work is in progress

What changed, and why?

Replaces the case assignments page with an edit volunteer page that includes the relevant editable volunteer fields.

How will this affect user permissions?

Admins can now edit a volunteer's name, email, and active/inactive status.

How is this tested?

Rspec tests have been added.

Screenshots please :)

Screen Shot 2020-04-28 at 1 16 48 PM


describe 'PATCH /update' do
it 'renders a csv file to download' do
it 'updates the user' do
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

end
end

describe 'PATCH /update' do
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@compwron compwron merged commit 6df2e50 into rubyforgood:master Apr 28, 2020
@compwron
Copy link
Copy Markdown
Collaborator

Very very cool! :)

@colinsoleim colinsoleim deleted the issue-5-edit-volunteer-page branch April 28, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit volunteer page for admins should display things Admin view/edit individual volunteer

2 participants