#1788 Add mobile number column to system imports for supervisors

[harsohailB]

What github issue is this PR for, if any?

Resolves #1788

What changed, and why?

• User data model to store phone number as a string
• supervisor_importer to include new column for phone numbers and validating the inputs in each row
• Seeding of data to include random generation of phone numbers for users using Faker

How will this affect user permissions?

• Volunteer permissions: N/A
• Supervisor permissions: N/A
• Admin permissions: N/A

How is this tested? (please write tests!) 💖💪

• Added phone numbers to existing supervisor data csv files
• Created new test csv test files for invalid inputs and missing phone numbers
• Created new tests in the supervisor importer spec file

Screenshots please :)

Valid Input:

Invalid Input:

• Input
  

• Error File
  

[compwron]

Specify correct format in error

[harsohailB]

Added as "Phone number is not in correct format: 1XXXXXXXXXX"!

[compwron]

Looks good

[compwron]

Some strange tests failing, I'm not sure what could have gone wrong there...

rspec './spec/datatables/reimbursement_datatable_spec.rb[1:2:5:1:1]' # ReimbursementDatatable multiple record handling order by case number behaves like a sorted results set should order ascending by default
rspec './spec/datatables/reimbursement_datatable_spec.rb[1:2:5:1:3:1]' # ReimbursementDatatable multiple record handling order by case number behaves like a sorted results set descending order should order correctly
rspec './spec/datatables/reimbursement_datatable_spec.rb[1:2:5:1:2:1]' # ReimbursementDatatable multiple record handling order by case number behaves like a sorted results set explicit ascending order should order correctly

[xihai01]

For your supervisor_import.rb file, I see that you are making validations for the phone number. But would it be better to handle these validations in the User model instead? Since volunteer, supervisor and admin all inherit from the User model and each of these users will need the same validations for phone numbers too.

https://guides.rubyonrails.org/active_record_validations.html#length

[harsohailB]

But would it be better to handle these validations in the User model instead?

@xihai01 Yes, this is a great point. I will make this change which will also help us bring the supervisor-importer function below the limit of 25 lines.

[harsohailB]

Some strange tests failing, I'm not sure what could have gone wrong there...

@compwron Yea not really sure what's happening here either as the rspec / rspec (pull_request check is passing.

[xihai01]

looks good to me and smart use of custom validators.

[FireLemons]

🥇